ascribe/onion
1
0
Fork 0
mirror of https://github.com/ascribe/onion.git synced 2024-12-22 09:23:13 +01:00
Code Issues Releases Wiki Activity

Use setTimeout instead of setInterval to refresh signed download urls

Browse Source
This commit is contained in:
Brett Sun 2016-03-10 12:06:58 +01:00
parent 64d0dd008e
commit 65c37b2c74
1 changed files with 20 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
js/components/ascribe_buttons/s3_download_button.js
View File

@ -30,15 +30,12 @@ const S3DownloadButton = React.createClass({
}, },
componentDidMount() { componentDidMount() {
/** // Initially, we request a signed url from the backend
* Initially, we request a signed url from
* the backend
*/
this.signUrl(); this.signUrl();
}, },
componentWillUnmount() { componentWillUnmount() {
window.clearInterval(this.state.signatureExpiryTimerId); window.clearTimeout(this.state.signatureExpiryTimerId);
}, },
transformS3UrlToS3Key(url) { transformS3UrlToS3Key(url) {
@ -52,29 +49,28 @@ const S3DownloadButton = React.createClass({
.signUrl(this.transformS3UrlToS3Key(url), title, artistName) .signUrl(this.transformS3UrlToS3Key(url), title, artistName)
.then(({ signed_url: downloadUrl }) => { .then(({ signed_url: downloadUrl }) => {
const { signatureExpiryTimerId } = this.state; const { signatureExpiryTimerId } = this.state;
let newState = { downloadUrl };
if(!signatureExpiryTimerId) { // The signed url, however can expire, which is why we need to set up a timer to
/** // renew it when it expires.
* The signed url, however can expire, which is why const expires = parseInt(queryParamsToArgs(downloadUrl.split('?')[1]).expires, 10);
* we need to renew it when it expires. const now = new Date().getTime() / 1000;
*/
const expires = parseInt(queryParamsToArgs(downloadUrl.split('?')[1]).expires, 10);
const now = new Date().getTime() / 1000;
/** // Amazon uses seconds as their signature unix timestamp while `setTimeout` uses
* Amazon uses seconds as their signature unix timestamp // milliseconds. Therefore we need to multiply with 1000.
* while `setInterval` uses milliseconds. Therefore we need to const interval = (expires - now) * 1000;
* multiply with 1000.
*/
const interval = (expires - now) * 1000;
Object.assign(newState, { // Make sure to clear the previous timeout just in case it was not the one that
// Substract 5s to make sure there is a big enough window to sign again before expiration // invoked the refetching
signatureExpiryTimerId: window.setInterval(this.signUrl, interval - 5000) if (signatureExpiryTimerId) {
}); window.clearTimeout(signatureExpiryTimerId);
} }
this.setState(newState);
this.setState({
downloadUrl,
// Substract 5s to make sure there is a big enough window to sign again before
// expiration
signatureExpiryTimerId: window.setTimeout(this.signUrl, interval - 5000)
});
}) })
.catch(console.logGlobal); .catch(console.logGlobal);
}, },