From 62ae8fd08b8656c7ad0d89f1ab5b36094f7c6989 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim=20Daubensch=C3=BCtz?= <tim@ascribe.io>
Date: Fri, 10 Jul 2015 14:15:22 +0200
Subject: [PATCH] fix warnings

---
 js/components/ascribe_detail/edition.js           |  9 ++++-----
 js/components/ascribe_detail/further_details.js   |  4 ++--
 .../ascribe_forms/form_piece_extradata.js         |  4 ++--
 .../ascribe_uploader/react_s3_fine_uploader.js    | 15 ++++++++++++---
 js/fetchers/coa_fetcher.js                        |  1 -
 5 files changed, 20 insertions(+), 13 deletions(-)

diff --git a/js/components/ascribe_detail/edition.js b/js/components/ascribe_detail/edition.js
index 73da8e65..36a234f8 100644
--- a/js/components/ascribe_detail/edition.js
+++ b/js/components/ascribe_detail/edition.js
@@ -279,7 +279,7 @@ let EditionPersonalNote = React.createClass({
                             editable={true}
                             defaultValue={this.props.edition.note_from_user}
                             placeholder={getLangText('Enter a personal note%s', '...')}
-                            required/>
+                            required="required"/>
                     </Property>
                     <Property hidden={true} name='bitcoin_id'>
                         <input defaultValue={this.props.edition.bitcoin_id}/>
@@ -317,8 +317,8 @@ let EditionPublicEditionNote = React.createClass({
                             rows={1}
                             editable={isEditable}
                             defaultValue={this.props.edition.public_note}
-                            placeholder={getLangText('Enter a public note for this edition%', '...')}
-                            required/>
+                            placeholder={getLangText('Enter a public note for this edition%s', '...')}
+                            required="required"/>
                     </Property>
                     <Property hidden={true} name='bitcoin_id'>
                         <input defaultValue={this.props.edition.bitcoin_id}/>
@@ -345,8 +345,7 @@ let CoaDetails = React.createClass({
         if (this.props.edition.coa) {
             CoaActions.fetchOne(this.props.edition.coa);
         }
-        else{
-            console.log('create coa');
+        else {
             CoaActions.create(this.props.edition);
         }
     },
diff --git a/js/components/ascribe_detail/further_details.js b/js/components/ascribe_detail/further_details.js
index bcb09280..8167a690 100644
--- a/js/components/ascribe_detail/further_details.js
+++ b/js/components/ascribe_detail/further_details.js
@@ -24,7 +24,7 @@ import { getCookie } from '../../utils/fetch_api_utils';
 let FurtherDetails = React.createClass({
     propTypes: {
         editable: React.PropTypes.bool,
-        pieceId: React.PropTypes.int,
+        pieceId: React.PropTypes.number,
         extraData: React.PropTypes.object,
         otherData: React.PropTypes.object,
         handleSuccess: React.PropTypes.func
@@ -105,7 +105,7 @@ let FurtherDetails = React.createClass({
 
 let FileUploader = React.createClass({
     propTypes: {
-        pieceId: React.PropTypes.int,
+        pieceId: React.PropTypes.number,
         otherData: React.PropTypes.object,
         setIsUploadReady: React.PropTypes.func,
         submitKey: React.PropTypes.func,
diff --git a/js/components/ascribe_forms/form_piece_extradata.js b/js/components/ascribe_forms/form_piece_extradata.js
index f0335e44..bbec9dca 100644
--- a/js/components/ascribe_forms/form_piece_extradata.js
+++ b/js/components/ascribe_forms/form_piece_extradata.js
@@ -13,7 +13,7 @@ import InputTextAreaToggable from './input_textarea_toggable';
 
 let PieceExtraDataForm = React.createClass({
     propTypes: {
-        pieceId: React.PropTypes.int,
+        pieceId: React.PropTypes.number,
         extraData: React.PropTypes.object,
         handleSuccess: React.PropTypes.func,
         name: React.PropTypes.string,
@@ -49,7 +49,7 @@ let PieceExtraDataForm = React.createClass({
                         editable={this.props.editable}
                         defaultValue={defaultValue}
                         placeholder={getLangText('Fill in%s', ' ') + this.props.title}
-                        required/>
+                        required="required"/>
                 </Property>
                 <hr />
             </Form>
diff --git a/js/components/ascribe_uploader/react_s3_fine_uploader.js b/js/components/ascribe_uploader/react_s3_fine_uploader.js
index 13b9d5c8..e206271a 100644
--- a/js/components/ascribe_uploader/react_s3_fine_uploader.js
+++ b/js/components/ascribe_uploader/react_s3_fine_uploader.js
@@ -24,11 +24,17 @@ var ReactS3FineUploader = React.createClass({
         keyRoutine: React.PropTypes.shape({
             url: React.PropTypes.string,
             fileClass: React.PropTypes.string,
-            pieceId: React.PropTypes.string
+            pieceId: React.PropTypes.oneOfType([
+                React.PropTypes.string,
+                React.PropTypes.number
+            ])
         }),
         createBlobRoutine: React.PropTypes.shape({
             url: React.PropTypes.string,
-            pieceId: React.PropTypes.string
+            pieceId: React.PropTypes.oneOfType([
+                React.PropTypes.string,
+                React.PropTypes.number
+            ])
         }),
         submitKey: React.PropTypes.func,
         autoUpload: React.PropTypes.bool,
@@ -70,7 +76,10 @@ var ReactS3FineUploader = React.createClass({
             customHeaders: React.PropTypes.object
         }).isRequired,
         session: React.PropTypes.shape({
-            endpoint: React.PropTypes.bool
+            customHeaders: React.PropTypes.object,
+            endpoint: React.PropTypes.string,
+            params: React.PropTypes.object,
+            refreshOnRequests: React.PropTypes.bool
         }),
         validation: React.PropTypes.shape({
             itemLimit: React.PropTypes.number,
diff --git a/js/fetchers/coa_fetcher.js b/js/fetchers/coa_fetcher.js
index 48ee9e73..e4956c66 100644
--- a/js/fetchers/coa_fetcher.js
+++ b/js/fetchers/coa_fetcher.js
@@ -11,7 +11,6 @@ let CoaFetcher = {
         return requests.get('coa', {'id': id});
     },
     create(bitcoinId) {
-        console.log(bitcoinId);
         return requests.post('coa_create', {body: {'bitcoin_id': bitcoinId}});
     }
 };