ascribe/onion
1
0
Fork 0
mirror of https://github.com/ascribe/onion.git synced 2024-12-22 17:33:14 +01:00
Code Issues Releases Wiki Activity

Add suggestion to refactor AclProxy to readme

Browse Source
This commit is contained in:
Brett Sun 2015-10-26 16:53:48 +01:00
parent da895bb434
commit 29e422d16a
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/refactor-todo.md
View File

@ -9,6 +9,7 @@ queryParams of the piece_list_store should all be reflected in the url and not a
- Refactor string-templating for api_urls
- Use classNames plugin instead of if-conditional-classes
- Instead of using `currentUser && currentUser.email` in an validation that checks whether we user is logged in or now, in the `UserStore` on login we set a boolean property called `isLoggedIn` that can then be used instead of `email`
- Refactor AclProxy to be a generic hide/show element component. Have it take data input and a validation function to assess whether it should show or hide child elements. Move current Acl checks to another place, eg. acl_utils.js.
# Refactor DONE
- Refactor forms to generic-declarative form component ✓