1
0
mirror of https://github.com/ascribe/onion.git synced 2024-11-15 01:25:17 +01:00

Sanitize utility should not modify given object

Mutating arguments and then returning them is redundant and confusing
behaviour (why pass it back if they already have it? Am I getting a new
copy since it returns something?).
This commit is contained in:
Brett Sun 2015-10-30 17:46:51 +01:00
parent d23331d9b9
commit 1e328b722b

View File

@ -1,9 +1,11 @@
'use strict';
import _ from 'lodash';
/**
* Takes an object and deletes all keys that are
*
* tagged as false by the passed in filter function
* Takes an object and returns a shallow copy without any keys
* that fail the passed in filter function.
* Does not modify the passed in object.
*
* @param {object} obj regular javascript object
* @return {object} regular javascript object without null values or empty strings
@ -15,15 +17,7 @@ export function sanitize(obj, filterFn) {
filterFn = (val) => val == null || val === '';
}
Object
.keys(obj)
.map((key) => {
if(filterFn(obj[key])) {
delete obj[key];
}
});
return obj;
return _.omit(obj, filterFn);
}
/**