From 17ec6f34e0557023303a3bfcd2dea41772aa0c08 Mon Sep 17 00:00:00 2001 From: vrde Date: Mon, 27 Jul 2015 18:21:20 +0200 Subject: [PATCH] Fix code after review --- js/app.js | 14 ++++++++++---- js/third_party/ga.js | 1 - js/third_party/intercom.js | 2 +- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/js/app.js b/js/app.js index f93a0cac..81a8fb82 100644 --- a/js/app.js +++ b/js/app.js @@ -5,7 +5,9 @@ require('babel/polyfill'); import React from 'react'; import Router from 'react-router'; +/* eslint-disable */ import fetch from 'isomorphic-fetch'; +/* eslint-enable */ import ApiUrls from './constants/api_urls'; import { updateApiUrls } from './constants/api_urls'; @@ -17,10 +19,14 @@ import { getSubdomainSettings } from './utils/constants_utils'; import { initLogging } from './utils/error_utils'; import EventActions from './actions/event_actions'; -// require('./third_party/debug'); -require('./third_party/ga'); -require('./third_party/raven'); -require('./third_party/intercom'); + +/* eslint-disable */ +// You can comment out the modules you don't need +// import DebugHandler from './third_party/debug'; +import GoogleAnalyticsHandler from './third_party/ga'; +import RavenHandler from './third_party/raven'; +import IntercomHandler from './third_party/intercom'; +/* eslint-enable */ initLogging(); diff --git a/js/third_party/ga.js b/js/third_party/ga.js index ccce35c7..52832623 100644 --- a/js/third_party/ga.js +++ b/js/third_party/ga.js @@ -10,7 +10,6 @@ class GoogleAnalyticsHandler { } onRouteDidChange() { - console.log(window.location.href); window.ga('send', 'pageview'); } diff --git a/js/third_party/intercom.js b/js/third_party/intercom.js index 405470bc..ef284d7b 100644 --- a/js/third_party/intercom.js +++ b/js/third_party/intercom.js @@ -16,7 +16,7 @@ class IntercomHandler { } /* eslint-disable */ - window.Intercom('boot', { + Intercom('boot', { /* eslint-enable */ app_id: 'oboxh5w1', email: profile.email,