ascribe/onion
1
0
Fork 0
mirror of https://github.com/ascribe/onion.git synced 2025-02-14 21:10:27 +01:00
Code Issues Releases Wiki Activity

documenting known issue with open/close state of edition list table

Browse Source
This commit is contained in:
Tim Daubenschütz 2015-06-04 10:25:31 +02:00
parent 4fe5766bc4
commit 0747c89a35
1 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
js/stores/piece_list_store.js
View File

@ -35,7 +35,6 @@ class PieceListStore {
} }
} }
}); });
console.log(this.pieceList, pieceId);
} }
onUpdatePieceList({ page, pageSize, search, pieceList, orderBy, orderAsc, pieceListCount }) { onUpdatePieceList({ page, pageSize, search, pieceList, orderBy, orderAsc, pieceListCount }) {
@ -44,8 +43,23 @@ class PieceListStore {
this.search = search; this.search = search;
this.orderAsc = orderAsc; this.orderAsc = orderAsc;
this.orderBy = orderBy; this.orderBy = orderBy;
this.pieceList = pieceList;
this.pieceListCount = pieceListCount; this.pieceListCount = pieceListCount;
/**
* The piece list store currently stores the open/close state of a piece list item.
*
* Once a new page is requested, this.pieceList will be overwritten, which means that the
* open/close state of a specific list item will be thrown away.
*
* This means that when opening an editionListTable on a piece, and continuing
* clicking next or back in the pagination, the editionListTable will return to its
* default value, which is "close".
*
* We did not implement this, as we're going to add pagination to pieceList at some
* point anyway. Then, this problem is automatically resolved.
*
*/
this.pieceList = pieceList;
} }
}; };